From 8df520721ced5762baf8b92fcc1001fd6078754b Mon Sep 17 00:00:00 2001
From: Ta-Ching Chen <contact@tachingchen.com>
Date: Tue, 23 Jan 2018 01:28:16 +0800
Subject: [PATCH] Add go vet check (#430)

* Add go vet check

* Replace go vet with go tool vet to avoid printing exit message
---
 .travis.yml                |  1 +
 builder/builder.go         |  4 ++--
 fission/timetrigger.go     |  2 +-
 fission/watch.go           |  2 +-
 hack/verify-govet.sh       | 15 +++++++++++++++
 kubewatcher/kubewatcher.go |  2 +-
 6 files changed, 21 insertions(+), 5 deletions(-)
 create mode 100755 hack/verify-govet.sh

diff --git a/.travis.yml b/.travis.yml
index 68d66368..7bdba056 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,6 +31,7 @@ script:
   - glide install
   - ./fission-bundle/build.sh
   - hack/verify-gofmt.sh
+  - hack/verify-govet.sh
   - hack/runtests.sh
   - test/build_and_test.sh
 
diff --git a/builder/builder.go b/builder/builder.go
index 44ac9b8e..16e09832 100644
--- a/builder/builder.go
+++ b/builder/builder.go
@@ -173,7 +173,7 @@ func (builder *Builder) build(command string, srcPkgPath string, deployPkgPath s
 
 	var buildLogs string
 
-	fmt.Println("\n=== Build Logs ===")
+	fmt.Printf("\n=== Build Logs ===")
 	// Init logs
 	fmt.Printf("command=%v\n", command)
 	fmt.Printf("env=%v\n", cmd.Env)
@@ -205,7 +205,7 @@ func (builder *Builder) build(command string, srcPkgPath string, deployPkgPath s
 		fmt.Println(cmdErr)
 		return buildLogs, cmdErr
 	}
-	fmt.Println("==================\n")
+	fmt.Printf("==================\n")
 
 	return buildLogs, nil
 }
diff --git a/fission/timetrigger.go b/fission/timetrigger.go
index 61009383..3f6ee26b 100644
--- a/fission/timetrigger.go
+++ b/fission/timetrigger.go
@@ -133,7 +133,7 @@ func ttList(c *cli.Context) error {
 
 	fmt.Fprintf(w, "%v\t%v\t%v\n", "NAME", "CRON", "FUNCTION_NAME")
 	for _, tt := range tts {
-		fmt.Fprintf(w, "%v\t%v\t%v\t%v\n",
+		fmt.Fprintf(w, "%v\t%v\t%v\n",
 			tt.Metadata.Name, tt.Spec.Cron, tt.Spec.FunctionReference.Name)
 	}
 	w.Flush()
diff --git a/fission/watch.go b/fission/watch.go
index 00e3a96f..769d9cc3 100644
--- a/fission/watch.go
+++ b/fission/watch.go
@@ -125,7 +125,7 @@ func wList(c *cli.Context) error {
 	fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\n",
 		"NAME", "NAMESPACE", "OBJTYPE", "LABELS", "FUNCTION_NAME")
 	for _, wa := range ws {
-		fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\t%v\n",
+		fmt.Fprintf(w, "%v\t%v\t%v\t%v\t%v\n",
 			wa.Metadata.Name, wa.Spec.Namespace, wa.Spec.Type, wa.Spec.LabelSelector, wa.Spec.FunctionReference.Name)
 	}
 	w.Flush()
diff --git a/hack/verify-govet.sh b/hack/verify-govet.sh
new file mode 100755
index 00000000..93d38a9a
--- /dev/null
+++ b/hack/verify-govet.sh
@@ -0,0 +1,15 @@
+#!/bin/bash
+
+set -o errexit
+set -o nounset
+set -o pipefail
+
+find_files() {
+  find . -not \( \
+      \( \
+        -wholename '*/vendor/*' \
+      \) -prune \
+    \) -name '*.go'
+}
+
+find_files | grep -v '.glide/cache' | xargs -I@ bash -c "go tool vet @"
diff --git a/kubewatcher/kubewatcher.go b/kubewatcher/kubewatcher.go
index 700998fc..83215c03 100644
--- a/kubewatcher/kubewatcher.go
+++ b/kubewatcher/kubewatcher.go
@@ -288,7 +288,7 @@ func (ws *watchSubscription) eventDispatchLoop() {
 
 		if ev.Type == watch.Error {
 			e := errors.FromObject(ev.Object)
-			log.Println("Watch error, retrying in a second: %v", e)
+			log.Printf("Watch error, retrying in a second: %v", e)
 			// Start from the beginning to get around "too old resource version"
 			ws.lastResourceVersion = ""
 			time.Sleep(time.Second)