Fix: false duplicate http trigger detection on specs re-apply (#3160)

* Fix false duplicate http trigger detection on specs re-apply

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>

* Use MetaObjectToName(m).String() from client-go instead of custom MapKey utility function

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>

---------

Signed-off-by: Md Soharab Ansari <soharab.ansari@infracloud.io>
This commit is contained in:
soharab-ic
2025-02-02 13:27:40 +05:30
committed by GitHub
parent 2853498a98
commit 8d70da4d8e
6 changed files with 86 additions and 87 deletions
+4 -3
View File
@@ -23,10 +23,11 @@ import (
"time"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
k8sCache "k8s.io/client-go/tools/cache"
fv1 "github.com/fission/fission/pkg/apis/core/v1"
"github.com/fission/fission/pkg/fission-cli/cmd"
"github.com/fission/fission/pkg/fission-cli/cmd/package/util"
pkgUtil "github.com/fission/fission/pkg/fission-cli/cmd/package/util"
)
type (
@@ -77,7 +78,7 @@ func (w *packageBuildWatcher) watch(ctx context.Context) {
keepWaiting := false
buildpkgs := make([]fv1.Package, 0)
for _, pkg := range pkgs.Items {
_, ok := w.pkgMeta[mapKey(&pkg.ObjectMeta)]
_, ok := w.pkgMeta[k8sCache.MetaObjectToName(&pkg.ObjectMeta).String()]
if !ok {
continue
}
@@ -101,7 +102,7 @@ func (w *packageBuildWatcher) watch(ctx context.Context) {
pkg.Status.BuildStatus == fv1.BuildStatusSucceeded {
w.finished[k] = true
fmt.Printf("------\n")
util.PrintPackageSummary(os.Stdout, &pkg)
pkgUtil.PrintPackageSummary(os.Stdout, &pkg)
fmt.Printf("------\n")
}
if pkg.Status.BuildStatus == fv1.BuildStatusFailed {