From 1d314b32d232d8861dc1d5c051e785889b621616 Mon Sep 17 00:00:00 2001 From: Soam Vasani Date: Thu, 9 Feb 2017 15:27:57 -0800 Subject: [PATCH] Don't wait for ready pod in MakeGenericPool Addresses issue #113. poolmgr.MakeGenericPool does not need to wait for a ready pod. Kubernetes already retries image fetching, so there's no need to repeat the task in fission. And if it's a non-retriable error (like the image URL being wrong), then the deployment will stay broken, and the user can fix the environment with 'fission env update' (or 'fission env delete' followed by 'fission env create'). --- poolmgr/gp.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/poolmgr/gp.go b/poolmgr/gp.go index d7a46faf5..cf8a6ee57 100644 --- a/poolmgr/gp.go +++ b/poolmgr/gp.go @@ -110,13 +110,7 @@ func MakeGenericPool( if err != nil { return nil, err } - - // wait for at least one pod to be ready - log.Printf("[%v] Deployment created, waiting for a ready pod", env.Metadata) - err = gp.waitForReadyPod() - if err != nil { - return nil, err - } + log.Printf("[%v] Deployment created", env.Metadata) go gp.choosePodService()