Add poolsize warning for environment create/update CLI (#1837)

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com> Co-authored-by: Sanket Sudake <sanketsudake@gmail.com>
2021-06-08 11:53:38 +05:30
parent 7bf82c7ea9
commit 827b64d633
2 changed files with 13 additions and 1 deletions
@@ -118,12 +118,20 @@ func createEnvironmentFromCmd(input cli.Input) (*fv1.Environment, error) {
 		envVersion = 1
 	}

-	poolsize := input.Int(flagkey.EnvPoolsize)
 	if input.IsSet(flagkey.EnvPoolsize) {
 		// TODO: remove silently version 3 assignment, we need to warn user to set it explicitly.
 		envVersion = 3
 	}

+	if !input.IsSet(flagkey.EnvPoolsize) {
+		console.Info("poolsize setting default to 3")
+	}
+
+	poolsize := input.Int(flagkey.EnvPoolsize)
+	if poolsize < 1 {
+		console.Warn("poolsize is not positive, if you are using pool manager please set postive value")
+	}
+
 	envBuilderImg := input.String(flagkey.EnvBuilderImage)
 	if len(envBuilderImg) > 0 {
 		if !input.IsSet(flagkey.EnvVersion) {