Add poolsize warning for environment create/update CLI (#1837)

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

Co-authored-by: Sanket Sudake <sanketsudake@gmail.com>

pkg/fission-cli/cmd/environment/create.go

@@ -118,12 +118,20 @@ func createEnvironmentFromCmd(input cli.Input) (*fv1.Environment, error) {
 		envVersion = 1
 	}
 
-	poolsize := input.Int(flagkey.EnvPoolsize)
 	if input.IsSet(flagkey.EnvPoolsize) {
 		// TODO: remove silently version 3 assignment, we need to warn user to set it explicitly.
 		envVersion = 3
 	}
 
+	if !input.IsSet(flagkey.EnvPoolsize) {
+		console.Info("poolsize setting default to 3")
+	}
+
+	poolsize := input.Int(flagkey.EnvPoolsize)
+	if poolsize < 1 {
+		console.Warn("poolsize is not positive, if you are using pool manager please set postive value")
+	}
+
 	envBuilderImg := input.String(flagkey.EnvBuilderImage)
 	if len(envBuilderImg) > 0 {
 		if !input.IsSet(flagkey.EnvVersion) {

pkg/fission-cli/cmd/environment/update.go

@@ -29,6 +29,7 @@ import (
 	fv1 "github.com/fission/fission/pkg/apis/core/v1"
 	"github.com/fission/fission/pkg/fission-cli/cliwrapper/cli"
 	"github.com/fission/fission/pkg/fission-cli/cmd"
+	"github.com/fission/fission/pkg/fission-cli/console"
 	flagkey "github.com/fission/fission/pkg/fission-cli/flag/key"
 	"github.com/fission/fission/pkg/utils"
 )
@@ -103,6 +104,9 @@ func updateExistingEnvironmentWithCmd(env *fv1.Environment, input cli.Input) (*f
 
 	if input.IsSet(flagkey.EnvPoolsize) {
 		env.Spec.Poolsize = input.Int(flagkey.EnvPoolsize)
+		if env.Spec.Poolsize < 1 {
+			console.Warn("poolsize is not positive, if you are using pool manager please set postive value")
+		}
 	}
 
 	if input.IsSet(flagkey.EnvGracePeriod) {