From 817616080243f0d46b943b52fd8138fca18be2cc Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Fri, 8 Nov 2019 23:15:15 +0800 Subject: [PATCH] Fix helm shows "Not a table" issue when install Fission (#1387) Helm treats the single line "extraCoreComponentPodConfig" in values.yaml as a key value pair config. ``` extraCoreComponentPodConfig: ``` And when a user tries to install helm with providing config like following, it failed. ``` extraCoreComponentPodConfig: nodeSelector: serverless: fission ``` The root cause is that helm treats config in default values.yaml and providing config as two different types of config, which is key-value vs. value table. And so it's unable for helm to merge these two configs even with the same key name. This PR comments out the single line config in default values.yaml to prevent the issue. --- charts/fission-all/values.yaml | 2 +- charts/fission-core/values.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/charts/fission-all/values.yaml b/charts/fission-all/values.yaml index 1fe654b23..bf2c84d6c 100644 --- a/charts/fission-all/values.yaml +++ b/charts/fission-all/values.yaml @@ -181,7 +181,7 @@ persistence: ## operator: In ## values: ## - app -extraCoreComponentPodConfig: +#extraCoreComponentPodConfig: # affinity: # tolerations: # nodeSelector: diff --git a/charts/fission-core/values.yaml b/charts/fission-core/values.yaml index ca91ca20f..68591e2f4 100644 --- a/charts/fission-core/values.yaml +++ b/charts/fission-core/values.yaml @@ -125,7 +125,7 @@ persistence: ## operator: In ## values: ## - app -extraCoreComponentPodConfig: +#extraCoreComponentPodConfig: # affinity: # tolerations: # nodeSelector: