From 7bd57c208a275f45c9adb72125523f1f484f3f70 Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Mon, 23 Sep 2019 14:25:49 +0800 Subject: [PATCH] Disable revision history for newdeploy (#1319) --- pkg/executor/newdeploy/newdeploy.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkg/executor/newdeploy/newdeploy.go b/pkg/executor/newdeploy/newdeploy.go index f077edbb..fd3f7537 100644 --- a/pkg/executor/newdeploy/newdeploy.go +++ b/pkg/executor/newdeploy/newdeploy.go @@ -183,6 +183,12 @@ func (deploy *NewDeploy) getDeploymentSpec(fn *fv1.Function, env *fv1.Environmen maxUnavailable := intstr.FromString("20%") maxSurge := intstr.FromString("100%") + // Newdeploy updates the environment variable "LastUpdateTimestamp" of deployment + // whenever a configmap/secret gets an update, but it also leaves multiple ReplicaSets for + // rollback purpose. Since fission always update a deployment instead of performing a + // rollback, set RevisionHistoryLimit to 0 to disable this feature. + revisionHistoryLimit := int32(0) + deployment := &v1beta1.Deployment{ ObjectMeta: metav1.ObjectMeta{ Name: deployName, @@ -242,6 +248,7 @@ func (deploy *NewDeploy) getDeploymentSpec(fn *fv1.Function, env *fv1.Environmen MaxSurge: &maxSurge, }, }, + RevisionHistoryLimit: &revisionHistoryLimit, }, }