Ignore errors from zap logger Sync (#2086)

Added golang CI lint
Reference issue: https://github.com/uber-go/zap/issues/880

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

.github/workflows/upgrade_test.yaml

@@ -1,10 +1,16 @@
-name: Upgrade functionality test
+name: Fission CI upgrade
 
-on: [workflow_dispatch]
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+  workflow_dispatch:
 
 jobs:
-  
+  upgrade-test:
-  upgrade-functionality-test:
     runs-on: ubuntu-latest
     steps:
     - name: Checkout action sources
@@ -24,13 +30,13 @@ jobs:
       uses: engineerd/setup-kind@v0.5.0
       with:
         config: kind.yaml
-        
+
     - name: Setup kubectl & fetch node information
       run: |
         kubectl cluster-info --context kind-kind
         kind get kubeconfig --internal >$HOME/.kube/config
         kubectl get nodes
-        
+
     - name: Dump system info
       run: |
         source ./test/upgrade_test/fission_objects.sh dump_system_info

.golangci.yaml

@@ -0,0 +1,7 @@
+linters-settings:
+  errcheck:
+    ignore: go.uber.org/zap:Sync
+  goimports:
+    # put imports beginning with prefix after 3rd-party packages;
+    # it's a comma-separated list of prefixes
+    local-prefixes: github.com/trussworks/my-cli-tool

cmd/builder/main.go

@@ -34,12 +34,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("can't initialize zap logger: %v", err)
 	}
-	defer func() {
+	defer logger.Sync()
-		err := logger.Sync()
-		if err != nil {
-			log.Fatal(err)
-		}
-	}()
 
 	shareVolume := os.Args[1]
 	if _, err := os.Stat(shareVolume); err != nil {

cmd/fetcher/main.go

@@ -33,11 +33,6 @@ func main() {
 	if err != nil {
 		log.Fatalf("can't initialize zap logger: %v", err)
 	}
-	defer func() {
+	defer logger.Sync()
-		err := logger.Sync()
-		if err != nil {
-			log.Fatal(err)
-		}
-	}()
 	app.Run(logger)
 }

cmd/fission-bundle/main.go

@@ -255,12 +255,7 @@ Options:
 	if err != nil {
 		log.Fatalf("I can't initialize zap logger: %v", err)
 	}
-	defer func() {
+	defer logger.Sync()
-		err := logger.Sync()
-		if err != nil {
-			log.Fatal(err)
-		}
-	}()
 	version := fmt.Sprintf("Fission Bundle Version: %v", info.BuildInfo().String())
 	arguments, err := docopt.ParseArgs(usage, nil, version)
 	if err != nil {

cmd/preupgradechecks/main.go

@@ -42,12 +42,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("can't initialize zap logger: %v", err)
 	}
-	defer func() {
+	defer logger.Sync()
-		err := logger.Sync()
-		if err != nil {
-			log.Fatal(err)
-		}
-	}()
 
 	usage := `Package to perform operations needed prior to fission installation
 Usage:

demos/declarative-specs/hello.go

@@ -6,7 +6,7 @@ import (
 )
 
 // Handler is the entry point for this fission function
-func Handler(w http.ResponseWriter, r *http.Request) { //nolint: deadcode
+func Handler(w http.ResponseWriter, r *http.Request) { //nolint:golint,unused,deadcode
 	msg := "Hello, CNCF Webinar!\n"
 	_, err := w.Write([]byte(msg))
 	if err != nil {

pkg/controller/client/v1/canaryconfig.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
+
 	"github.com/fission/fission/pkg/controller/client/rest"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/controller/client/v1/environment.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
+
 	"github.com/fission/fission/pkg/controller/client/rest"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/controller/client/v1/fake/fake_misc.go

@@ -18,6 +18,7 @@ package fake
 
 import (
 	"io"
+
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 
 	v1 "github.com/fission/fission/pkg/controller/client/v1"

pkg/controller/client/v1/httptrigger.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
+
 	"github.com/fission/fission/pkg/controller/client/rest"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/controller/client/v1/mqtrigger.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
+
 	"github.com/fission/fission/pkg/controller/client/rest"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/controller/client/v1/package.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
+
 	"github.com/fission/fission/pkg/controller/client/rest"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/controller/client/v1/timetrigger.go

@@ -19,6 +19,7 @@ package v1
 import (
 	"encoding/json"
 	"fmt"
+
 	"github.com/fission/fission/pkg/controller/client/rest"
 
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

pkg/fission-cli/cmd/timetrigger/create.go

@@ -18,9 +18,10 @@ package timetrigger
 
 import (
 	"fmt"
-	"github.com/fission/fission/pkg/fission-cli/cmd"
 	"time"
 
+	"github.com/fission/fission/pkg/fission-cli/cmd"
+
 	"github.com/pkg/errors"
 	"github.com/robfig/cron"
 	uuid "github.com/satori/go.uuid"

pkg/generator/encoder/encoder.go

@@ -18,6 +18,7 @@ package encoder
 
 import (
 	"encoding/json"
+
 	"github.com/ghodss/yaml"
 )
 

test/tests/test_huge_response/hello.go

@@ -7,7 +7,7 @@ import (
 )
 
 // Handler is the entry point for this fission function
-func Handler(w http.ResponseWriter, r *http.Request) { //nolint: deadcode
+func Handler(w http.ResponseWriter, r *http.Request) { //nolint:golint,unused,deadcode
 	bytes, err := ioutil.ReadAll(r.Body)
 	if err != nil {
 		http.Error(w, err.Error(), http.StatusInternalServerError)