Add Container object to environment build and runtime specs (#413)
Environment Specs so far had only an image URL to specify a container image. This was fine for public images but fell short in a few of cases: (a) Using private image registries (b) Specifying environment variables (this is needed for workflows helm install) (c) Setting a SecurityContext for the container This change adds the Container object to both build and runtime Environments. Compatibility is preserved -- the existing ImageURL field is still used. See the comments in types.go for the overriding rules in the case that both Container and ImageURL are specified.
This commit is contained in:
committed by
Soam Vasani
parent
c76b6bacc0
commit
70a93a7302
+19
-13
@@ -389,28 +389,34 @@ run_all_tests() {
|
||||
|
||||
for file in $test_files
|
||||
do
|
||||
testname=${file#$ROOT/test/tests}
|
||||
testpath=$file
|
||||
run_test ${file}
|
||||
done
|
||||
}
|
||||
|
||||
if grep "^#test:disabled" $file
|
||||
run_test() {
|
||||
file=$1
|
||||
|
||||
test_name=${file#${ROOT}/test/tests}
|
||||
test_path=${file}
|
||||
|
||||
if grep "^#test:disabled" ${file}
|
||||
then
|
||||
report_test_skipped $testname
|
||||
echo ------- Skipped $testname -------
|
||||
report_test_skipped ${test_name}
|
||||
echo ------- Skipped ${test_name} -------
|
||||
else
|
||||
echo ------- Running $testname -------
|
||||
pushd $(dirname $testpath)
|
||||
if $testpath
|
||||
echo ------- Running ${test_name} -------
|
||||
pushd $(dirname ${test_path})
|
||||
if ${test_path}
|
||||
then
|
||||
echo SUCCESS: $testname
|
||||
report_test_passed $testname
|
||||
echo [SUCCESS]: ${test_name}
|
||||
report_test_passed ${test_name}
|
||||
else
|
||||
echo FAILED: $testname
|
||||
echo [FAILED]: ${test_name}
|
||||
export FAILURES=$(($FAILURES+1))
|
||||
report_test_failed $testname
|
||||
report_test_failed ${test_name}
|
||||
fi
|
||||
popd
|
||||
fi
|
||||
done
|
||||
}
|
||||
|
||||
install_and_test() {
|
||||
|
||||
Reference in New Issue
Block a user