From 70876e5c348b2c201352c82eed295cf641a3cfa0 Mon Sep 17 00:00:00 2001 From: Ta-Ching Chen Date: Wed, 27 Nov 2019 00:28:48 +0800 Subject: [PATCH] Fix router tries to update ingress when createIngress is false (#1440) --- pkg/router/ingress.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/router/ingress.go b/pkg/router/ingress.go index 9bd5401db..bbd622f2e 100644 --- a/pkg/router/ingress.go +++ b/pkg/router/ingress.go @@ -71,6 +71,9 @@ func deleteIngress(logger *zap.Logger, trigger *fv1.HTTPTrigger, kubeClient *kub } func updateIngress(logger *zap.Logger, oldT *fv1.HTTPTrigger, newT *fv1.HTTPTrigger, kubeClient *kubernetes.Clientset) { + if !oldT.Spec.CreateIngress && !newT.Spec.CreateIngress { + return + } if !oldT.Spec.CreateIngress && newT.Spec.CreateIngress { createIngress(logger, newT, kubeClient)