Remove controller component from Fission (#2850)

* Remove controller component from Fission
* Cleanup at few more places

---------

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

pkg/fission-cli/cmd/package/util/util.go

@@ -30,7 +30,6 @@ import (
 	uuid "github.com/satori/go.uuid"
 
 	fv1 "github.com/fission/fission/pkg/apis/core/v1"
-	"github.com/fission/fission/pkg/controller/client"
 	"github.com/fission/fission/pkg/fission-cli/cmd"
 	"github.com/fission/fission/pkg/fission-cli/util"
 	storageSvcClient "github.com/fission/fission/pkg/storagesvc/client"
@@ -238,23 +237,6 @@ func WriteArchiveToFile(fileName string, reader io.Reader) error {
 	return nil
 }
 
-// DownloadStoragesvcURL downloads and return archive content with given storage service url
-func DownloadStoragesvcURL(client client.Interface, fileUrl string) (io.ReadCloser, error) {
-	u, err := url.ParseRequestURI(fileUrl)
-	if err != nil {
-		return nil, err
-	}
-
-	// replace in-cluster storage service host with controller server url
-	fileDownloadUrl := strings.TrimSuffix(client.ServerURL(), "/") + "/proxy/storage/" + u.RequestURI()
-	reader, err := DownloadURL(fileDownloadUrl)
-	if err != nil {
-		return nil, errors.Wrapf(err, fmt.Sprintf("error downloading from storage service url: %v", fileUrl))
-	}
-
-	return reader, nil
-}
-
 // PrintPackageSummary prints package information and build logs.
 func PrintPackageSummary(writer io.Writer, pkg *fv1.Package) {
 	// replace escaped line breaker character