Split out the Package type into a first class Kubernetes resource (#295)

Split out the Package type into a first class Kubernetes resource. Before this change, packages were implicitly tied to functions.

This wasn't ideal because:
 * Functions will need to share packages
 * A package storage system may be more generally useful than just
   functions (for example, for storing static assets)

This change does the following:
* Updates the fission and tpr types to add a new Package and PackageSpec.  It also creates a PackageRef type, and a FunctionPackageRef type. The PackageRef simply references a package, but the FunctionPackageRef includes the name of a function within the package. This allows us to share packages between different functions.
* Updates fetcher and other components for first-class packages
* Allows customization of fetcher image pull policy in the helm charts

poolmgr/gp.go

@@ -50,20 +50,21 @@ const POD_PHASE_RUNNING string = "Running"
 
 type (
 	GenericPool struct {
-		env              *tpr.Environment
-		replicas         int32                 // num idle pods
-		deployment       *v1beta1.Deployment   // kubernetes deployment
-		namespace        string                // namespace to keep our resources
-		podReadyTimeout  time.Duration         // timeout for generic pods to become ready
-		idlePodReapTime  time.Duration         // pods unused for idlePodReapTime are deleted
-		fsCache          *functionServiceCache // cache funcSvc's by function, address and podname
-		useSvc           bool                  // create k8s service for specialized pods
-		poolInstanceId   string                // small random string to uniquify pod names
-		fetcherImage     string
-		kubernetesClient *kubernetes.Clientset
-		instanceId       string // poolmgr instance id
-		labelsForPool    map[string]string
-		requestChannel   chan *choosePodRequest
+		env                    *tpr.Environment
+		replicas               int32                 // num idle pods
+		deployment             *v1beta1.Deployment   // kubernetes deployment
+		namespace              string                // namespace to keep our resources
+		podReadyTimeout        time.Duration         // timeout for generic pods to become ready
+		idlePodReapTime        time.Duration         // pods unused for idlePodReapTime are deleted
+		fsCache                *functionServiceCache // cache funcSvc's by function, address and podname
+		useSvc                 bool                  // create k8s service for specialized pods
+		poolInstanceId         string                // small random string to uniquify pod names
+		fetcherImage           string
+		fetcherImagePullPolicy v1.PullPolicy
+		kubernetesClient       *kubernetes.Clientset
+		instanceId             string // poolmgr instance id
+		labelsForPool          map[string]string
+		requestChannel         chan *choosePodRequest
 	}
 
 	// serialize the choosing of pods so that choices don't conflict
@@ -91,6 +92,10 @@ func MakeGenericPool(
 	if len(fetcherImage) == 0 {
 		fetcherImage = "fission/fetcher"
 	}
+	fetcherImagePullPolicyS := os.Getenv("FETCHER_IMAGE_PULL_POLICY")
+	if len(fetcherImagePullPolicyS) == 0 {
+		fetcherImagePullPolicyS = "IfNotPresent"
+	}
 
 	// TODO: in general we need to provide the user a way to configure pools.  Initial
 	// replicas, autoscaling params, various timeouts, etc.
@@ -109,6 +114,17 @@ func MakeGenericPool(
 		useSvc:           false, // defaults off -- svc takes a second or more to become routable, slowing cold start
 	}
 
+	switch fetcherImagePullPolicyS {
+	case "Always":
+		gp.fetcherImagePullPolicy = v1.PullAlways
+	case "Never":
+		gp.fetcherImagePullPolicy = v1.PullNever
+	default:
+		gp.fetcherImagePullPolicy = v1.PullIfNotPresent
+	}
+
+	log.Printf("fetcher image: %v, pull policy: %v", gp.fetcherImage, gp.fetcherImagePullPolicy)
+
 	// Labels for generic deployment/RS/pods.
 	gp.labelsForPool = map[string]string{
 		"environmentName":        gp.env.Metadata.Name,
@@ -376,7 +392,7 @@ func (gp *GenericPool) createPool() error {
 						{
 							Name:                   "fetcher",
 							Image:                  gp.fetcherImage,
-							ImagePullPolicy:        v1.PullIfNotPresent,
+							ImagePullPolicy:        gp.fetcherImagePullPolicy,
 							TerminationMessagePath: "/dev/termination-log",
 							VolumeMounts: []v1.VolumeMount{
 								{

poolmgr/poolmgr_test.go

@@ -63,6 +63,7 @@ func createTestNamespace(kubeClient *kubernetes.Clientset, ns string) {
 	if err != nil {
 		log.Panicf("failed to create ns %v: %v", ns, err)
 	}
+	log.Printf("Created namespace %v", ns)
 }
 
 // create a nodeport service
@@ -172,6 +173,22 @@ func TestPoolmgr(t *testing.T) {
 	// waitForPool(functionNs, "nodejs")
 	time.Sleep(6 * time.Second)
 
+	// create a package
+	p := &tpr.Package{
+		Metadata: api.ObjectMeta{
+			Name:      "hello",
+			Namespace: fissionNs,
+		},
+		Spec: fission.PackageSpec{
+			Type:    fission.PackageTypeLiteral,
+			Literal: []byte(`module.exports = async function(context) { return { status: 200, body: "Hello, world!\n" }; }`),
+		},
+	}
+	_, err = fissionClient.Packages(fissionNs).Create(p)
+	if err != nil {
+		log.Panicf("failed to create package: %v", err)
+	}
+
 	// create a function
 	f := &tpr.Function{
 		Metadata: api.ObjectMeta{
@@ -179,10 +196,12 @@ func TestPoolmgr(t *testing.T) {
 			Namespace: fissionNs,
 		},
 		Spec: fission.FunctionSpec{
-			Source: fission.Package{},
-			Deployment: fission.Package{
-				Type:    fission.PackageTypeLiteral,
-				Literal: []byte(`module.exports = async function(context) { return { status: 200, body: "Hello, world!\n" }; }`),
+			Source: fission.FunctionPackageRef{},
+			Deployment: fission.FunctionPackageRef{
+				PackageRef: fission.PackageRef{
+					Name:      p.Metadata.Name,
+					Namespace: p.Metadata.Namespace,
+				},
 			},
 			EnvironmentName: env.Metadata.Name,
 		},