Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix newdeploy backend failed to delete deployment due to incorrect resource version (#657)

Browse Source
This commit is contained in:
Ta-Ching Chen
2018-05-01 16:48:34 +08:00
committed by GitHub
parent 0aff2f214d
commit 6a7381c575
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
executor/newdeploy/newdeploymgr.go
+7 -2
View File
@@ -480,9 +480,14 @@ func (deploy *NewDeploy) fnDelete(fn *crd.Function) (*fscache.FuncSvc, error) {
var delError error var delError error
fsvc, err := deploy.fsCache.GetByFunction(&fn.Metadata) // GetByFunction uses resource version as part of cache key, however,
// the resource version in function metadata will be changed when a function
// is deleted and cause newdeploy backend fails to delete the entry.
// Use GetByFunctionUID instead of GetByFunction here to find correct
// fsvc entry.
fsvc, err := deploy.fsCache.GetByFunctionUID(fn.Metadata.UID)
if err != nil { if err != nil {
log.Printf("fsvc not fonud in cache: %v", fn.Metadata) log.Printf("fsvc not found in cache: %v", fn.Metadata)
delError = err delError = err
return nil, err return nil, err
} }