Fixed golangci-lint issues: /fission/pkg (#1902)

pkg/storagesvc/client/storagesvc_test.go

@@ -126,7 +126,12 @@ func TestS3StorageService(t *testing.T) {
 		log.Fatalf("Could not connect to docker: %s", err)
 	}
 
-	defer pool.Purge(resource)
+	defer func() {
+		err := pool.Purge(resource)
+		if err != nil {
+			log.Fatal(err)
+		}
+	}()
 
 	// Start storagesvc
 	bucketName := "test-s3-service"

pkg/storagesvc/storagesvc.go

@@ -65,7 +65,10 @@ func getStorageLocation(config *storageConfig) (stow.Location, error) {
 // Handle multipart file uploads.
 func (ss *StorageService) uploadHandler(w http.ResponseWriter, r *http.Request) {
 	// handle upload
-	r.ParseMultipartForm(0)
+	err := r.ParseMultipartForm(0)
+	if err != nil {
+		http.Error(w, "failed to parse request", http.StatusBadRequest)
+	}
 	file, handler, err := r.FormFile("uploadfile")
 	if err != nil {
 		http.Error(w, "missing upload file", http.StatusBadRequest)
@@ -121,7 +124,15 @@ func (ss *StorageService) uploadHandler(w http.ResponseWriter, r *http.Request)
 		http.Error(w, "Error marshaling response", http.StatusInternalServerError)
 		return
 	}
-	w.Write(resp)
+	_, err = w.Write(resp)
+	if err != nil {
+		ss.logger.Error(
+			"error writing HTTP response",
+			zap.Error(err),
+			zap.String("filename", handler.Filename),
+		)
+	}
+
 }
 
 func (ss *StorageService) getIdFromRequest(r *http.Request) (string, error) {

pkg/storagesvc/stowClient.go

@@ -171,8 +171,7 @@ func (client *StowClient) getItemIDsWithFilter(filterFunc filter, filterFuncPara
 	for {
 		items, cursor, err = client.container.Items(stow.NoPrefix, cursor, PaginationSize)
 		if err != nil {
-			errors.Wrap(err, "error getting items from container")
-			return nil, err
+			return nil, errors.Wrap(err, "error getting items from container")
 		}
 
 		for _, item := range items {