Fixed golangci-lint issues: /fission/pkg (#1902)

This commit is contained in:
Gaurav Gahlot
2021-01-19 23:29:20 +05:30
committed by GitHub
parent 6dbdf4d88b
commit 695b0759e4
21 changed files with 178 additions and 66 deletions
+14 -2
View File
@@ -74,7 +74,13 @@ func MakeBuilder(logger *zap.Logger, sharedVolumePath string) *Builder {
func (builder *Builder) VersionHandler(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json; charset=utf-8")
w.Write([]byte(info.BuildInfo().String()))
_, err := w.Write([]byte(info.BuildInfo().String()))
if err != nil {
builder.logger.Error(
"error writing response",
zap.Error(err),
)
}
}
func (builder *Builder) Handler(w http.ResponseWriter, r *http.Request) {
@@ -149,7 +155,13 @@ func (builder *Builder) reply(w http.ResponseWriter, pkgFilename string, buildLo
// should write header before writing the body,
// or client will receive HTTP 200 regardless the real status code
w.WriteHeader(statusCode)
w.Write(rBody)
_, err = w.Write(rBody)
if err != nil {
builder.logger.Error(
"error writing response",
zap.Error(err),
)
}
}
func (builder *Builder) build(command string, srcPkgPath string, deployPkgPath string) (string, error) {