Capture os signals to gracefully shutdown fission components (#2261)

- Currently, fission components don't handle shutdown signals.
So we don't get any to do the required cleanup before the fission process
exits. Adding signal capture process with cancelling context so
that all dependent processes stop working when the process gets term
signal.
- Set log level to error in otel shutdown function

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
This commit is contained in:
Sanket Sudake
2021-11-11 17:02:11 +05:30
committed by GitHub
parent d260f07acb
commit 59e876062f
26 changed files with 161 additions and 115 deletions
+4 -7
View File
@@ -17,6 +17,7 @@ limitations under the License.
package logger
import (
"context"
"fmt"
"log"
"os"
@@ -32,7 +33,6 @@ import (
fv1 "github.com/fission/fission/pkg/apis/core/v1"
"github.com/fission/fission/pkg/crd"
"github.com/fission/fission/pkg/utils"
"github.com/fission/fission/pkg/utils/loggerfactory"
)
var nodeName = os.Getenv("NODE_NAME")
@@ -157,10 +157,7 @@ func symlinkReaper(zapLogger *zap.Logger) {
}
}
func Start() {
logger := loggerfactory.GetLogger()
defer logger.Sync()
func Start(ctx context.Context, logger *zap.Logger) {
if _, err := os.Stat(fissionSymlinkPath); os.IsNotExist(err) {
logger.Info("symlink path not exist, create it",
zap.String("fissionSymlinkPath", fissionSymlinkPath))
@@ -177,6 +174,6 @@ func Start() {
informerFactory := k8sInformers.NewSharedInformerFactory(kubernetesClient, time.Minute*30)
podInformer := informerFactory.Core().V1().Pods().Informer()
podInformer.AddEventHandler(podInformerHandlers(logger))
podInformer.Run(make(chan struct{}))
logger.Fatal("Stop watching pod changes")
podInformer.Run(ctx.Done())
logger.Error("Stop watching pod changes")
}