Use code-generator to generate clientset/informer/lister (#1492)

To reduce maintenance effort and avoid writing duplicate informer code,
use code-generator to generate clientset/informer/lister code.

pkg/apis/fission.io/v1/README.md

@@ -1,14 +0,0 @@
-# Fission CRD generation
-
-* Use [code-generator](https://github.com/kubernetes/code-generator) to generate fission CRD object deepcopy and client methods.
-
-``` bash
-$ vendor/k8s.io/code-generator/generate-groups.sh deepcopy \
-    github.com/fission/fission/pkg/client \
-    github.com/fission/fission/pkg/apis \
-    fission.io:v1
-```
-
-# Reference
-
-* https://blog.openshift.com/kubernetes-deep-dive-code-generation-customresources/

pkg/apis/fission.io/v1/doc.go

@@ -17,13 +17,13 @@ limitations under the License.
 // This file tells deepcopy-gen to generate deepcopy methods for all structs in the package.
 // For more details, please visit https://blog.openshift.com/kubernetes-deep-dive-code-generation-customresources/
 
-// +k8s:deepcopy-gen=package
+// +k8s:deepcopy-gen=package,register
 // +k8s:defaulter-gen=TypeMeta
 // +groupName=fission.io
+// +groupGoName=V1
 package v1
 
 const (
-	CRD_VERSION = "fission.io/v1"
-
+	CRD_VERSION          = "fission.io/v1"
 	CRD_NAME_ENVIRONMENT = "Environment"
 )

pkg/apis/fission.io/v1/register.go

@@ -0,0 +1,70 @@
+/*
+Copyright 2019 The Kubernetes Authors.
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+    http://www.apache.org/licenses/LICENSE-2.0
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+// The file comes from Kubernetes code-generator repo with custom modification.
+// https://github.com/kubernetes/code-generator/blob/0826954c61ed88ac5d75e771ade6aae646ca5268/_examples/HyphenGroup/apis/example/v1/register.go
+
+package v1
+
+import (
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/runtime"
+	"k8s.io/apimachinery/pkg/runtime/schema"
+)
+
+var SchemeGroupVersion = schema.GroupVersion{Group: "fission.io", Version: "v1"}
+
+var (
+	// TODO: move SchemeBuilder with zz_generated.deepcopy.go to k8s.io/api.
+	// localSchemeBuilder and AddToScheme will stay in k8s.io/kubernetes.
+	SchemeBuilder      runtime.SchemeBuilder
+	localSchemeBuilder = &SchemeBuilder
+	AddToScheme        = localSchemeBuilder.AddToScheme
+)
+
+func init() {
+	// We only register manually written functions here. The registration of the
+	// generated functions takes place in the generated files. The separation
+	// makes the code compile even when the generated files are missing.
+	localSchemeBuilder.Register(addKnownTypes)
+}
+
+// Resource takes an unqualified resource and returns a Group qualified GroupResource
+func Resource(resource string) schema.GroupResource {
+	return SchemeGroupVersion.WithResource(resource).GroupResource()
+}
+
+// Adds the list of known types to the given scheme.
+func addKnownTypes(scheme *runtime.Scheme) error {
+	scheme.AddKnownTypes(
+		SchemeGroupVersion,
+		&Function{},
+		&FunctionList{},
+		&Environment{},
+		&EnvironmentList{},
+		&HTTPTrigger{},
+		&HTTPTriggerList{},
+		&KubernetesWatchTrigger{},
+		&KubernetesWatchTriggerList{},
+		&TimeTrigger{},
+		&TimeTriggerList{},
+		&MessageQueueTrigger{},
+		&MessageQueueTriggerList{},
+		&Package{},
+		&PackageList{},
+		&CanaryConfig{},
+		&CanaryConfigList{},
+	)
+	metav1.AddToGroupVersion(scheme, SchemeGroupVersion)
+	return nil
+}

pkg/apis/fission.io/v1/typeDeepcopyFunc.go

@@ -1,266 +0,0 @@
-/*
-Copyright 2019 The Fission Authors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-   http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-package v1
-
-import (
-	"github.com/hashicorp/go-multierror"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime/schema"
-)
-
-// Each CRD type needs:
-//   GetObjectKind (to satisfy the Object interface)
-//
-// In addition, each singular CRD type needs:
-//   GetObjectMeta (to satisfy the ObjectMetaAccessor interface)
-//
-// And each list CRD type needs:
-//   GetListMeta (to satisfy the ListMetaAccessor interface)
-
-func (f *Function) GetObjectKind() schema.ObjectKind {
-	return &f.TypeMeta
-}
-func (e *Environment) GetObjectKind() schema.ObjectKind {
-	return &e.TypeMeta
-}
-func (ht *HTTPTrigger) GetObjectKind() schema.ObjectKind {
-	return &ht.TypeMeta
-}
-func (w *KubernetesWatchTrigger) GetObjectKind() schema.ObjectKind {
-	return &w.TypeMeta
-}
-func (t *TimeTrigger) GetObjectKind() schema.ObjectKind {
-	return &t.TypeMeta
-}
-func (m *MessageQueueTrigger) GetObjectKind() schema.ObjectKind {
-	return &m.TypeMeta
-}
-func (p *Package) GetObjectKind() schema.ObjectKind {
-	return &p.TypeMeta
-}
-func (c *CanaryConfig) GetObjectKind() schema.ObjectKind {
-	return &c.TypeMeta
-}
-
-func (f *Function) GetObjectMeta() metav1.Object {
-	return &f.Metadata
-}
-func (e *Environment) GetObjectMeta() metav1.Object {
-	return &e.Metadata
-}
-func (ht *HTTPTrigger) GetObjectMeta() metav1.Object {
-	return &ht.Metadata
-}
-func (w *KubernetesWatchTrigger) GetObjectMeta() metav1.Object {
-	return &w.Metadata
-}
-func (t *TimeTrigger) GetObjectMeta() metav1.Object {
-	return &t.Metadata
-}
-func (m *MessageQueueTrigger) GetObjectMeta() metav1.Object {
-	return &m.Metadata
-}
-func (p *Package) GetObjectMeta() metav1.Object {
-	return &p.Metadata
-}
-func (c *CanaryConfig) GetObjectMeta() metav1.Object {
-	return &c.Metadata
-}
-
-func (fl *FunctionList) GetObjectKind() schema.ObjectKind {
-	return &fl.TypeMeta
-}
-func (el *EnvironmentList) GetObjectKind() schema.ObjectKind {
-	return &el.TypeMeta
-}
-func (hl *HTTPTriggerList) GetObjectKind() schema.ObjectKind {
-	return &hl.TypeMeta
-}
-func (wl *KubernetesWatchTriggerList) GetObjectKind() schema.ObjectKind {
-	return &wl.TypeMeta
-}
-func (wl *TimeTriggerList) GetObjectKind() schema.ObjectKind {
-	return &wl.TypeMeta
-}
-func (ml *MessageQueueTriggerList) GetObjectKind() schema.ObjectKind {
-	return &ml.TypeMeta
-}
-func (pl *PackageList) GetObjectKind() schema.ObjectKind {
-	return &pl.TypeMeta
-}
-
-func (cl *CanaryConfigList) GetObjectKind() schema.ObjectKind {
-	return &cl.TypeMeta
-}
-
-func (fl *FunctionList) GetListMeta() metav1.ListInterface {
-	return &fl.Metadata
-}
-func (el *EnvironmentList) GetListMeta() metav1.ListInterface {
-	return &el.Metadata
-}
-func (hl *HTTPTriggerList) GetListMeta() metav1.ListInterface {
-	return &hl.Metadata
-}
-func (wl *KubernetesWatchTriggerList) GetListMeta() metav1.ListInterface {
-	return &wl.Metadata
-}
-func (wl *TimeTriggerList) GetListMeta() metav1.ListInterface {
-	return &wl.Metadata
-}
-func (ml *MessageQueueTriggerList) GetListMeta() metav1.ListInterface {
-	return &ml.Metadata
-}
-func (pl *PackageList) GetListMeta() metav1.ListInterface {
-	return &pl.Metadata
-}
-
-func (cl *CanaryConfigList) GetListMeta() metav1.ListInterface {
-	return &cl.Metadata
-}
-
-func validateMetadata(field string, m metav1.ObjectMeta) error {
-	return ValidateKubeReference(field, m.Name, m.Namespace)
-}
-
-func (p *Package) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("Package", p.Metadata),
-		p.Spec.Validate(),
-		p.Status.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (pl *PackageList) Validate() error {
-	result := &multierror.Error{}
-	// not validate ListMeta
-	for _, p := range pl.Items {
-		result = multierror.Append(result, p.Validate())
-	}
-	return result.ErrorOrNil()
-}
-
-func (f *Function) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("Function", f.Metadata),
-		f.Spec.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (fl *FunctionList) Validate() error {
-	result := &multierror.Error{}
-	for _, f := range fl.Items {
-		result = multierror.Append(result, f.Validate())
-	}
-	return result.ErrorOrNil()
-}
-
-func (e *Environment) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("Environment", e.Metadata),
-		e.Spec.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (el *EnvironmentList) Validate() error {
-	result := &multierror.Error{}
-	for _, e := range el.Items {
-		result = multierror.Append(result, e.Validate())
-	}
-	return result.ErrorOrNil()
-}
-
-func (h *HTTPTrigger) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("HTTPTrigger", h.Metadata),
-		h.Spec.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (hl *HTTPTriggerList) Validate() error {
-	result := &multierror.Error{}
-	for _, h := range hl.Items {
-		result = multierror.Append(result, h.Validate())
-	}
-	return result.ErrorOrNil()
-}
-
-func (k *KubernetesWatchTrigger) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("KubernetesWatchTrigger", k.Metadata),
-		k.Spec.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (kl *KubernetesWatchTriggerList) Validate() error {
-	result := &multierror.Error{}
-	for _, k := range kl.Items {
-		result = multierror.Append(result, k.Validate())
-	}
-	return result
-}
-
-func (t *TimeTrigger) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("TimeTrigger", t.Metadata),
-		t.Spec.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (tl *TimeTriggerList) Validate() error {
-	result := &multierror.Error{}
-	for _, t := range tl.Items {
-		result = multierror.Append(result, t.Validate())
-	}
-	return result.ErrorOrNil()
-}
-
-func (m *MessageQueueTrigger) Validate() error {
-	result := &multierror.Error{}
-
-	result = multierror.Append(result,
-		validateMetadata("MessageQueueTrigger", m.Metadata),
-		m.Spec.Validate())
-
-	return result.ErrorOrNil()
-}
-
-func (ml *MessageQueueTriggerList) Validate() error {
-	result := &multierror.Error{}
-	for _, m := range ml.Items {
-		result = multierror.Append(result, m.Validate())
-	}
-	return result.ErrorOrNil()
-}

pkg/apis/fission.io/v1/types.go

@@ -17,14 +17,10 @@ limitations under the License.
 package v1
 
 import (
-	"time"
-
 	apiv1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
-
 //
 // To add a Fission CRD type:
 //   1. Create a "spec" type, for everything in the type except metadata
@@ -42,11 +38,13 @@ import (
 type (
 
 	// Packages. Think of these as function-level images.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	Package struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta `json:"metadata"`
-		Spec            PackageSpec       `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+
+		Spec PackageSpec `json:"spec"`
 
 		// Status indicates the build status of package.
 		Status PackageStatus `json:"status"`
@@ -56,121 +54,130 @@ type (
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	PackageList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta `json:"metadata"`
-		Items           []Package       `json:"items"`
+		metav1.ListMeta `json:"metadata"`
+		Items           []Package `json:"items"`
 	}
 
 	// Function is function runs within environment runtime with given package and secrets/configmaps.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	Function struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta `json:"metadata"`
-		Spec            FunctionSpec      `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+		Spec              FunctionSpec `json:"spec"`
 	}
 
 	// FunctionList is a list of Functions.
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	FunctionList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta `json:"metadata"`
-		Items           []Function      `json:"items"`
+		metav1.ListMeta `json:"metadata"`
+		Items           []Function `json:"items"`
 	}
 
 	// Environment is environment for building and running user functions.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	Environment struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta `json:"metadata"`
-		Spec            EnvironmentSpec   `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+		Spec              EnvironmentSpec `json:"spec"`
 	}
 
 	// EnvironmentList is a list of Environments.
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	EnvironmentList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta `json:"metadata"`
-		Items           []Environment   `json:"items"`
+		metav1.ListMeta `json:"metadata"`
+		Items           []Environment `json:"items"`
 	}
 
 	// HTTPTrigger is the trigger invokes user functions when receiving HTTP requests.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	HTTPTrigger struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta `json:"metadata"`
-		Spec            HTTPTriggerSpec   `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+		Spec              HTTPTriggerSpec `json:"spec"`
 	}
 
 	// HTTPTriggerList is a list of HTTPTriggers
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	HTTPTriggerList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta `json:"metadata"`
-		Items           []HTTPTrigger   `json:"items"`
+		metav1.ListMeta `json:"metadata"`
+		Items           []HTTPTrigger `json:"items"`
 	}
 
 	// KubernetesWatchTrigger watches kubernetes resource events and invokes functions.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	KubernetesWatchTrigger struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta          `json:"metadata"`
-		Spec            KubernetesWatchTriggerSpec `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+		Spec              KubernetesWatchTriggerSpec `json:"spec"`
 	}
 
 	// KubernetesWatchTriggerList is a list of KubernetesWatchTriggers
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	KubernetesWatchTriggerList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta          `json:"metadata"`
+		metav1.ListMeta `json:"metadata"`
 		Items           []KubernetesWatchTrigger `json:"items"`
 	}
 
 	// TimeTrigger invokes functions based on given cron schedule.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	TimeTrigger struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta `json:"metadata"`
-		Spec            TimeTriggerSpec   `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+
+		Spec TimeTriggerSpec `json:"spec"`
 	}
 
 	// TimeTriggerList is a list of TimeTriggers.
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	TimeTriggerList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta `json:"metadata"`
+		metav1.ListMeta `json:"metadata"`
 
 		Items []TimeTrigger `json:"items"`
 	}
 
 	// MessageQueueTrigger invokes functions when messages arrive to certain topic that trigger subscribes to.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	MessageQueueTrigger struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta       `json:"metadata"`
-		Spec            MessageQueueTriggerSpec `json:"spec"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+
+		Spec MessageQueueTriggerSpec `json:"spec"`
 	}
 
 	// MessageQueueTriggerList is a list of MessageQueueTriggers.
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	MessageQueueTriggerList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta       `json:"metadata"`
+		metav1.ListMeta `json:"metadata"`
 		Items           []MessageQueueTrigger `json:"items"`
 	}
 
 	// CanaryConfig is for canary deployment of two functions.
+	// +genclient
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	CanaryConfig struct {
-		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ObjectMeta  `json:"metadata"`
-		Spec            CanaryConfigSpec   `json:"spec"`
-		Status          CanaryConfigStatus `json:"status"`
+		metav1.TypeMeta   `json:",inline"`
+		metav1.ObjectMeta `json:"metadata"`
+		Spec              CanaryConfigSpec   `json:"spec"`
+		Status            CanaryConfigStatus `json:"status"`
 	}
 
 	// CanaryConfigList is a list of CanaryConfigs.
 	// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 	CanaryConfigList struct {
 		metav1.TypeMeta `json:",inline"`
-		Metadata        metav1.ListMeta `json:"metadata"`
+		metav1.ListMeta `json:"metadata"`
 
 		Items []CanaryConfig `json:"items"`
 	}
@@ -267,7 +274,9 @@ type (
 		BuildLog string `json:"buildlog,omitempty"` // output of the build (errors etc)
 
 		// LastUpdateTimestamp will store the timestamp the package was last updated
-		LastUpdateTimestamp time.Time `json:"lastUpdateTimestamp,omitempty"`
+		// metav1.Time is a wrapper around time.Time which supports correct marshaling to YAML and JSON.
+		// https://github.com/kubernetes/apimachinery/blob/44bd77c24ef93cd3a5eb6fef64e514025d10d44e/pkg/apis/meta/v1/time.go#L26-L35
+		LastUpdateTimestamp metav1.Time `json:"lastUpdateTimestamp,omitempty"`
 	}
 
 	// PackageRef is a reference to the package.

pkg/apis/fission.io/v1/validation.go

@@ -25,6 +25,7 @@ import (
 	"github.com/hashicorp/go-multierror"
 	nsUtil "github.com/nats-io/nats-streaming-server/util"
 	"github.com/robfig/cron"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/util/validation"
 )
 
@@ -556,3 +557,135 @@ func (spec TimeTriggerSpec) Validate() error {
 
 	return result.ErrorOrNil()
 }
+
+func validateMetadata(field string, m metav1.ObjectMeta) error {
+	return ValidateKubeReference(field, m.Name, m.Namespace)
+}
+
+func (p *Package) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("Package", p.ObjectMeta),
+		p.Spec.Validate(),
+		p.Status.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (pl *PackageList) Validate() error {
+	result := &multierror.Error{}
+	// not validate ListMeta
+	for _, p := range pl.Items {
+		result = multierror.Append(result, p.Validate())
+	}
+	return result.ErrorOrNil()
+}
+
+func (f *Function) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("Function", f.ObjectMeta),
+		f.Spec.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (fl *FunctionList) Validate() error {
+	result := &multierror.Error{}
+	for _, f := range fl.Items {
+		result = multierror.Append(result, f.Validate())
+	}
+	return result.ErrorOrNil()
+}
+
+func (e *Environment) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("Environment", e.ObjectMeta),
+		e.Spec.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (el *EnvironmentList) Validate() error {
+	result := &multierror.Error{}
+	for _, e := range el.Items {
+		result = multierror.Append(result, e.Validate())
+	}
+	return result.ErrorOrNil()
+}
+
+func (h *HTTPTrigger) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("HTTPTrigger", h.ObjectMeta),
+		h.Spec.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (hl *HTTPTriggerList) Validate() error {
+	result := &multierror.Error{}
+	for _, h := range hl.Items {
+		result = multierror.Append(result, h.Validate())
+	}
+	return result.ErrorOrNil()
+}
+
+func (k *KubernetesWatchTrigger) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("KubernetesWatchTrigger", k.ObjectMeta),
+		k.Spec.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (kl *KubernetesWatchTriggerList) Validate() error {
+	result := &multierror.Error{}
+	for _, k := range kl.Items {
+		result = multierror.Append(result, k.Validate())
+	}
+	return result
+}
+
+func (t *TimeTrigger) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("TimeTrigger", t.ObjectMeta),
+		t.Spec.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (tl *TimeTriggerList) Validate() error {
+	result := &multierror.Error{}
+	for _, t := range tl.Items {
+		result = multierror.Append(result, t.Validate())
+	}
+	return result.ErrorOrNil()
+}
+
+func (m *MessageQueueTrigger) Validate() error {
+	result := &multierror.Error{}
+
+	result = multierror.Append(result,
+		validateMetadata("MessageQueueTrigger", m.ObjectMeta),
+		m.Spec.Validate())
+
+	return result.ErrorOrNil()
+}
+
+func (ml *MessageQueueTriggerList) Validate() error {
+	result := &multierror.Error{}
+	for _, m := range ml.Items {
+		result = multierror.Append(result, m.Validate())
+	}
+	return result.ErrorOrNil()
+}

pkg/apis/fission.io/v1/zz_generated.deepcopy.go

@@ -1,7 +1,7 @@
 // +build !ignore_autogenerated
 
 /*
-Copyright The Kubernetes Authors.
+Copyright The Fission Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -55,6 +55,11 @@ func (in *Builder) DeepCopyInto(out *Builder) {
 		*out = new(corev1.Container)
 		(*in).DeepCopyInto(*out)
 	}
+	if in.PodSpec != nil {
+		in, out := &in.PodSpec, &out.PodSpec
+		*out = new(corev1.PodSpec)
+		(*in).DeepCopyInto(*out)
+	}
 	return
 }
 
@@ -72,7 +77,7 @@ func (in *Builder) DeepCopy() *Builder {
 func (in *CanaryConfig) DeepCopyInto(out *CanaryConfig) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	out.Spec = in.Spec
 	out.Status = in.Status
 	return
@@ -100,7 +105,7 @@ func (in *CanaryConfig) DeepCopyObject() runtime.Object {
 func (in *CanaryConfigList) DeepCopyInto(out *CanaryConfigList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]CanaryConfig, len(*in))
@@ -197,7 +202,7 @@ func (in *ConfigMapReference) DeepCopy() *ConfigMapReference {
 func (in *Environment) DeepCopyInto(out *Environment) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	return
 }
@@ -224,7 +229,7 @@ func (in *Environment) DeepCopyObject() runtime.Object {
 func (in *EnvironmentList) DeepCopyInto(out *EnvironmentList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]Environment, len(*in))
@@ -308,7 +313,7 @@ func (in *ExecutionStrategy) DeepCopy() *ExecutionStrategy {
 func (in *Function) DeepCopyInto(out *Function) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	return
 }
@@ -335,7 +340,7 @@ func (in *Function) DeepCopyObject() runtime.Object {
 func (in *FunctionList) DeepCopyInto(out *FunctionList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]Function, len(*in))
@@ -438,7 +443,7 @@ func (in *FunctionSpec) DeepCopy() *FunctionSpec {
 func (in *HTTPTrigger) DeepCopyInto(out *HTTPTrigger) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	return
 }
@@ -465,7 +470,7 @@ func (in *HTTPTrigger) DeepCopyObject() runtime.Object {
 func (in *HTTPTriggerList) DeepCopyInto(out *HTTPTriggerList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]HTTPTrigger, len(*in))
@@ -498,6 +503,7 @@ func (in *HTTPTriggerList) DeepCopyObject() runtime.Object {
 func (in *HTTPTriggerSpec) DeepCopyInto(out *HTTPTriggerSpec) {
 	*out = *in
 	in.FunctionReference.DeepCopyInto(&out.FunctionReference)
+	in.IngressConfig.DeepCopyInto(&out.IngressConfig)
 	return
 }
 
@@ -511,6 +517,29 @@ func (in *HTTPTriggerSpec) DeepCopy() *HTTPTriggerSpec {
 	return out
 }
 
+// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
+func (in *IngressConfig) DeepCopyInto(out *IngressConfig) {
+	*out = *in
+	if in.Annotations != nil {
+		in, out := &in.Annotations, &out.Annotations
+		*out = make(map[string]string, len(*in))
+		for key, val := range *in {
+			(*out)[key] = val
+		}
+	}
+	return
+}
+
+// DeepCopy is an autogenerated deepcopy function, copying the receiver, creating a new IngressConfig.
+func (in *IngressConfig) DeepCopy() *IngressConfig {
+	if in == nil {
+		return nil
+	}
+	out := new(IngressConfig)
+	in.DeepCopyInto(out)
+	return out
+}
+
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *InvokeStrategy) DeepCopyInto(out *InvokeStrategy) {
 	*out = *in
@@ -532,7 +561,7 @@ func (in *InvokeStrategy) DeepCopy() *InvokeStrategy {
 func (in *KubernetesWatchTrigger) DeepCopyInto(out *KubernetesWatchTrigger) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	return
 }
@@ -559,7 +588,7 @@ func (in *KubernetesWatchTrigger) DeepCopyObject() runtime.Object {
 func (in *KubernetesWatchTriggerList) DeepCopyInto(out *KubernetesWatchTriggerList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]KubernetesWatchTrigger, len(*in))
@@ -616,7 +645,7 @@ func (in *KubernetesWatchTriggerSpec) DeepCopy() *KubernetesWatchTriggerSpec {
 func (in *MessageQueueTrigger) DeepCopyInto(out *MessageQueueTrigger) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	return
 }
@@ -643,7 +672,7 @@ func (in *MessageQueueTrigger) DeepCopyObject() runtime.Object {
 func (in *MessageQueueTriggerList) DeepCopyInto(out *MessageQueueTriggerList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]MessageQueueTrigger, len(*in))
@@ -693,9 +722,9 @@ func (in *MessageQueueTriggerSpec) DeepCopy() *MessageQueueTriggerSpec {
 func (in *Package) DeepCopyInto(out *Package) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
-	out.Status = in.Status
+	in.Status.DeepCopyInto(&out.Status)
 	return
 }
 
@@ -721,7 +750,7 @@ func (in *Package) DeepCopyObject() runtime.Object {
 func (in *PackageList) DeepCopyInto(out *PackageList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]Package, len(*in))
@@ -788,6 +817,7 @@ func (in *PackageSpec) DeepCopy() *PackageSpec {
 // DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
 func (in *PackageStatus) DeepCopyInto(out *PackageStatus) {
 	*out = *in
+	in.LastUpdateTimestamp.DeepCopyInto(&out.LastUpdateTimestamp)
 	return
 }
 
@@ -809,6 +839,11 @@ func (in *Runtime) DeepCopyInto(out *Runtime) {
 		*out = new(corev1.Container)
 		(*in).DeepCopyInto(*out)
 	}
+	if in.PodSpec != nil {
+		in, out := &in.PodSpec, &out.PodSpec
+		*out = new(corev1.PodSpec)
+		(*in).DeepCopyInto(*out)
+	}
 	return
 }
 
@@ -842,7 +877,7 @@ func (in *SecretReference) DeepCopy() *SecretReference {
 func (in *TimeTrigger) DeepCopyInto(out *TimeTrigger) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	in.Metadata.DeepCopyInto(&out.Metadata)
+	in.ObjectMeta.DeepCopyInto(&out.ObjectMeta)
 	in.Spec.DeepCopyInto(&out.Spec)
 	return
 }
@@ -869,7 +904,7 @@ func (in *TimeTrigger) DeepCopyObject() runtime.Object {
 func (in *TimeTriggerList) DeepCopyInto(out *TimeTriggerList) {
 	*out = *in
 	out.TypeMeta = in.TypeMeta
-	out.Metadata = in.Metadata
+	in.ListMeta.DeepCopyInto(&out.ListMeta)
 	if in.Items != nil {
 		in, out := &in.Items, &out.Items
 		*out = make([]TimeTrigger, len(*in))