Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ability to retain specialised pods for poolmanager functions (#2830)

Browse Source 
- added retainPods flag to take in the number of specialized pods to retain
- add retainPods in both the create function and update function command
- modify crd keys to be typed instead of string
- keep track of function generation in case of update function operation
- add delete handler function to make sure specialized pods are deleted in case function is deleted

---------

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
Signed-off-by: Pranoy Kundu <pranoy1998k@gmail.com>
Co-authored-by: Pranoy Kundu <pranoy1998k@gmail.com>
This commit is contained in:
Sanket Sudake
2023-09-27 13:33:19 +05:30
committed by GitHub
co-authored by Pranoy Kundu
parent 657aee7cc2
commit 56b49dcee8
26 changed files with 405 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/fission-cli/cmd/function/command.go
+2 -2
View File
@@ -36,7 +36,7 @@ func Commands() *cobra.Command {
flag.FnExecutorType, flag.FnCfgMap, flag.FnSecret,
flag.FnSpecializationTimeout, flag.FnExecutionTimeout,
flag.FnIdleTimeout, flag.FnConcurrency, flag.FnRequestsPerPod,
flag.FnOnceOnly, flag.Labels, flag.Annotation,
flag.FnOnceOnly, flag.Labels, flag.Annotation, flag.FnRetainPods,
// TODO retired pkg & trigger related flags from function cmd
flag.PkgCode, flag.PkgSrcArchive, flag.PkgDeployArchive,
@@ -87,7 +87,7 @@ func Commands() *cobra.Command {
flag.FnExecutorType, flag.FnSecret, flag.FnCfgMap,
flag.FnSpecializationTimeout, flag.FnExecutionTimeout,
flag.FnIdleTimeout, flag.FnConcurrency, flag.FnRequestsPerPod,
flag.FnOnceOnly, flag.Labels, flag.Annotation,
flag.FnOnceOnly, flag.Labels, flag.Annotation, flag.FnRetainPods,
flag.PkgCode, flag.PkgSrcArchive, flag.PkgDeployArchive,
flag.PkgSrcChecksum, flag.PkgDeployChecksum, flag.PkgInsecure,
pkg/fission-cli/cmd/function/create.go
+2
View File
@@ -104,6 +104,7 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
}
requestsPerPod := input.Int(flagkey.FnRequestsPerPod)
retainPods := input.Int(flagkey.FnRetainPods)
fnOnceOnly := input.Bool(flagkey.FnOnceOnly)
@@ -306,6 +307,7 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
IdleTimeout: &fnIdleTimeout,
Concurrency: fnConcurrency,
RequestsPerPod: requestsPerPod,
RetainPods: retainPods,
OnceOnly: fnOnceOnly,
},
}
pkg/fission-cli/cmd/function/update.go
+4
View File
@@ -162,6 +162,10 @@ func (opts *UpdateSubCommand) complete(input cli.Input) error {
function.Spec.RequestsPerPod = input.Int(flagkey.FnRequestsPerPod)
}
if input.IsSet(flagkey.FnRetainPods) {
function.Spec.RetainPods = input.Int(flagkey.FnRetainPods)
}
if input.IsSet(flagkey.FnOnceOnly) {
function.Spec.OnceOnly = input.Bool(flagkey.FnOnceOnly)
}