Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(cli): provide imagepullsecret option for container as function (#2680)

Browse Source 
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
This commit is contained in:
Shubham Nazare
2023-01-09 16:18:56 +05:30
committed by GitHub
parent 6667d7e383
commit 496e4e3162
4 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/fission-cli/cmd/function/command.go
+1
View File
@@ -173,6 +173,7 @@ func Commands() *cobra.Command {
flag.RunTimeMinCPU, flag.RunTimeMaxCPU, flag.RunTimeMinMemory, flag.RunTimeMinCPU, flag.RunTimeMaxCPU, flag.RunTimeMinMemory,
flag.RunTimeMaxMemory, flag.ReplicasMin, flag.RunTimeMaxMemory, flag.ReplicasMin,
flag.ReplicasMax, flag.RunTimeTargetCPU, flag.ReplicasMax, flag.RunTimeTargetCPU,
flag.RunImagePullSecret,
flag.NamespaceFunction, flag.SpecSave, flag.SpecDry, flag.NamespaceFunction, flag.SpecSave, flag.SpecDry,
}, },
pkg/fission-cli/cmd/function/run_container.go
+3
View File
@@ -106,6 +106,8 @@ func (opts *RunContainerSubCommand) complete(input cli.Input) error {
console.Warn("grace period must be a non-negative integer, using default value (6 mins)") console.Warn("grace period must be a non-negative integer, using default value (6 mins)")
} }
pullSecret := []apiv1.LocalObjectReference{{Name: input.String(flagkey.RunImagePullSecret)}}
var imageName string var imageName string
var port int var port int
var command, args string var command, args string
@@ -208,6 +210,7 @@ func (opts *RunContainerSubCommand) complete(input cli.Input) error {
opts.function.Spec.PodSpec = &apiv1.PodSpec{ opts.function.Spec.PodSpec = &apiv1.PodSpec{
Containers: []apiv1.Container{*container}, Containers: []apiv1.Container{*container},
TerminationGracePeriodSeconds: &fnGracePeriod, TerminationGracePeriodSeconds: &fnGracePeriod,
ImagePullSecrets: pullSecret,
} }
return nil return nil
pkg/fission-cli/flag/flag.go
+1
View File
@@ -96,6 +96,7 @@ var (
RunTimeTargetCPU = Flag{Type: Int, Name: flagkey.RuntimeTargetcpu, Usage: "Target average CPU usage percentage across pods for scaling", DefaultValue: 80} RunTimeTargetCPU = Flag{Type: Int, Name: flagkey.RuntimeTargetcpu, Usage: "Target average CPU usage percentage across pods for scaling", DefaultValue: 80}
RunTimeMinMemory = Flag{Type: Int, Name: flagkey.RuntimeMinmemory, Usage: "Minimum memory to be assigned to pod (In megabyte)"} RunTimeMinMemory = Flag{Type: Int, Name: flagkey.RuntimeMinmemory, Usage: "Minimum memory to be assigned to pod (In megabyte)"}
RunTimeMaxMemory = Flag{Type: Int, Name: flagkey.RuntimeMaxmemory, Usage: "Maximum memory to be assigned to pod (In megabyte)"} RunTimeMaxMemory = Flag{Type: Int, Name: flagkey.RuntimeMaxmemory, Usage: "Maximum memory to be assigned to pod (In megabyte)"}
RunImagePullSecret = Flag{Type: String, Name: flagkey.RunImagePullSecret, Usage: "Secret for Kubernetes to pull an image from a private registry"}
ReplicasMin = Flag{Type: Int, Name: flagkey.ReplicasMinscale, Usage: "Minimum number of pods (Uses resource inputs to configure HPA)", DefaultValue: 1} ReplicasMin = Flag{Type: Int, Name: flagkey.ReplicasMinscale, Usage: "Minimum number of pods (Uses resource inputs to configure HPA)", DefaultValue: 1}
ReplicasMax = Flag{Type: Int, Name: flagkey.ReplicasMaxscale, Usage: "Maximum number of pods (Uses resource inputs to configure HPA)", DefaultValue: 1} ReplicasMax = Flag{Type: Int, Name: flagkey.ReplicasMaxscale, Usage: "Maximum number of pods (Uses resource inputs to configure HPA)", DefaultValue: 1}
pkg/fission-cli/flag/key/key.go
+6 -5
View File
@@ -44,11 +44,12 @@ const (
NamespacePod = "pod-namespace" NamespacePod = "pod-namespace"
ForceDelete = "force" ForceDelete = "force"
RuntimeMincpu = "mincpu" RuntimeMincpu = "mincpu"
RuntimeMaxcpu = "maxcpu" RuntimeMaxcpu = "maxcpu"
RuntimeMinmemory = "minmemory" RuntimeMinmemory = "minmemory"
RuntimeMaxmemory = "maxmemory" RuntimeMaxmemory = "maxmemory"
RuntimeTargetcpu = "targetcpu" RuntimeTargetcpu = "targetcpu"
RunImagePullSecret = "imagepullsecret"
ReplicasMinscale = "minscale" ReplicasMinscale = "minscale"
ReplicasMaxscale = "maxscale" ReplicasMaxscale = "maxscale"