From 43814450e53a62b27cb09c86de17c1152de21f2a Mon Sep 17 00:00:00 2001
From: Sanket Sudake <sanketsudake@gmail.com>
Date: Mon, 5 Jul 2021 14:57:11 +0530
Subject: [PATCH] Increase timeout for kubectl test (#2100)

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
---
 .github/workflows/push_pr.yaml          |  6 +++---
 .github/workflows/upgrade_test.yaml     | 14 +++++++++++++-
 kind.yaml                               |  3 +--
 test/tests/test_kubectl/test_kubectl.sh |  8 ++++----
 4 files changed, 21 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/push_pr.yaml b/.github/workflows/push_pr.yaml
index 178cfd74..bd38dcde 100644
--- a/.github/workflows/push_pr.yaml
+++ b/.github/workflows/push_pr.yaml
@@ -62,6 +62,7 @@ jobs:
         with:
           image:  ${{ matrix.kindimage }}
           version:  v0.11.1
+          config: kind.yaml
 
       - name: Configuring and testing the Installation
         run: |
@@ -107,14 +108,13 @@ jobs:
         run: ./test/kind_CI.sh
 
       - name: Collect Fission Dump
-        if: ${{ failure() }}
         run: |
-          fission support dump
+          command -v fission && fission support dump
 
       - name: Archive fission dump
         if: ${{ failure() }}
         uses: actions/upload-artifact@v2
         with:
-          name: fission-support-dump
+          name: fission-dump
           path: fission-dump/*.zip
           retention-days: 5
\ No newline at end of file
diff --git a/.github/workflows/upgrade_test.yaml b/.github/workflows/upgrade_test.yaml
index d42b99a8..88877272 100644
--- a/.github/workflows/upgrade_test.yaml
+++ b/.github/workflows/upgrade_test.yaml
@@ -81,4 +81,16 @@ jobs:
 
     - name: Test previously created fission objects with new release
       run: |
-        source ./test/upgrade_test/fission_objects.sh test_fission_objects
\ No newline at end of file
+        source ./test/upgrade_test/fission_objects.sh test_fission_objects
+
+    - name: Collect Fission Dump
+      run: |
+        command -v fission && fission support dump
+
+    - name: Archive fission dump
+      if: ${{ failure() }}
+      uses: actions/upload-artifact@v2
+      with:
+        name: fission-dump
+        path: fission-dump/*.zip
+        retention-days: 5
\ No newline at end of file
diff --git a/kind.yaml b/kind.yaml
index 5f70fe36..654f0397 100644
--- a/kind.yaml
+++ b/kind.yaml
@@ -8,7 +8,6 @@ kind: Cluster
 apiVersion: kind.x-k8s.io/v1alpha4
 nodes:
 - role: control-plane
-  image: kindest/node:v1.19.11
   kubeadmConfigPatches:
     - |
       kind: InitConfiguration
@@ -22,4 +21,4 @@ nodes:
     protocol: TCP
   - containerPort: 443
     hostPort: 443
-    protocol: TCP
\ No newline at end of file
+    protocol: TCP
diff --git a/test/tests/test_kubectl/test_kubectl.sh b/test/tests/test_kubectl/test_kubectl.sh
index b8d7fe60..58bc1048 100755
--- a/test/tests/test_kubectl/test_kubectl.sh
+++ b/test/tests/test_kubectl/test_kubectl.sh
@@ -31,17 +31,17 @@ pkgName="go-b4bbb0e0-2d93-47f0-8c4e-eea644eec2a9"
 kubectl apply -f spec-yaml -R
 
 # wait for build to finish
-timeout 90 bash -c "wait_for_builder $name"
-timeout 90 bash -c "waitBuildExpectedStatus $pkgName failed"
+timeout 180 bash -c "wait_for_builder $name"
+timeout 180 bash -c "waitBuildExpectedStatus $pkgName failed"
 
 sed -i 's/gogo/go/g' spec-yaml/function-go.yaml
 
 # before we enable "/status" this should be failed.
 kubectl apply -f spec-yaml/function-go.yaml
-timeout 90 bash -c "waitBuildExpectedStatus $pkgName failed"
+timeout 180 bash -c "waitBuildExpectedStatus $pkgName failed"
 
 kubectl replace -f spec-yaml/function-go.yaml
-timeout 90 bash -c "waitBuild $pkgName"
+timeout 180 bash -c "waitBuild $pkgName"
 
 fission fn test --name $name