Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix code comments function names (#2927)

Browse Source 
Signed-off-by: eveneast <qcqs@foxmail.com>
This commit is contained in:
eveneast
2024-05-20 19:22:22 +05:30
committed by GitHub
parent 932be4eb38
commit 3e43c07e5a
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/crd/key.go
+1 -1
View File
@@ -42,7 +42,7 @@ func (ck CacheKeyURG) String() string {
return fmt.Sprintf("%v_%v_%v", ck.UID, ck.ResourceVersion, ck.Generation) return fmt.Sprintf("%v_%v_%v", ck.UID, ck.ResourceVersion, ck.Generation)
} }
// CacheKeyForUID create a key that uniquely identifies the // CacheKeyUIDFromMeta create a key that uniquely identifies the
// of the object. Since resourceVersion changes on every update and // of the object. Since resourceVersion changes on every update and
// UIDs are unique, we don't use resource version here // UIDs are unique, we don't use resource version here
func CacheKeyUIDFromMeta(metadata *metav1.ObjectMeta) types.UID { func CacheKeyUIDFromMeta(metadata *metav1.ObjectMeta) types.UID {
pkg/executor/fscache/poolcache.go
+2 -2
View File
@@ -355,7 +355,7 @@ func (c *PoolCache) MarkFuncDeleted(function crd.CacheKeyURG) {
} }
} }
// GetValue returns a function service with status in Active else return error // GetSvcValue returns a function service with status in Active else return error
func (c *PoolCache) GetSvcValue(ctx context.Context, function crd.CacheKeyURG, requestsPerPod int, concurrency int) (*FuncSvc, error) { func (c *PoolCache) GetSvcValue(ctx context.Context, function crd.CacheKeyURG, requestsPerPod int, concurrency int) (*FuncSvc, error) {
respChannel := make(chan *response) respChannel := make(chan *response)
c.requestChannel <- &request{ c.requestChannel <- &request{
@@ -390,7 +390,7 @@ func (c *PoolCache) ListAvailableValue() []*FuncSvc {
return resp.allValues return resp.allValues
} }
// SetValue marks the value at key [function][address] as active(begin used) // SetSvcValue marks the value at key [function][address] as active(begin used)
func (c *PoolCache) SetSvcValue(ctx context.Context, function crd.CacheKeyURG, address string, value *FuncSvc, cpuLimit resource.Quantity, requestsPerPod, svcsRetain int) { func (c *PoolCache) SetSvcValue(ctx context.Context, function crd.CacheKeyURG, address string, value *FuncSvc, cpuLimit resource.Quantity, requestsPerPod, svcsRetain int) {
respChannel := make(chan *response) respChannel := make(chan *response)
c.requestChannel <- &request{ c.requestChannel <- &request{
pkg/fission-cli/cmd/function/create.go
+1 -1
View File
@@ -334,7 +334,7 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
return nil return nil
} }
// generatePackgeName => will return package name by appending id in function name and will make sure that package name will never be more than length of 63 characters. // generatePackageName => will return package name by appending id in function name and will make sure that package name will never be more than length of 63 characters.
func generatePackageName(fnName string, id string) string { func generatePackageName(fnName string, id string) string {
var ( var (
lenFnName int = len(fnName) lenFnName int = len(fnName)