Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

removed unused reference of TRACING_SAMPLING_RATE (#2498)

Browse Source
This commit is contained in:
Shubham Bansal
2022-07-27 14:30:30 +05:30
committed by GitHub
parent 5c886e4cf4
commit 3c8edab514
1 changed files with 2 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/router/router.go
+2 -12
View File
@@ -79,7 +79,7 @@ func router(ctx context.Context, logger *zap.Logger, httpTriggerSet *HTTPTrigger
return mr
}
func serve(ctx context.Context, logger *zap.Logger, port int, tracingSamplingRate float64,
func serve(ctx context.Context, logger *zap.Logger, port int,
httpTriggerSet *HTTPTriggerSet, displayAccessLog bool) {
mr := router(ctx, logger, httpTriggerSet)
handler := otelUtils.GetHandlerWithOTEL(mr, "fission-router", otelUtils.UrlsToIgnore("/router-healthz"))
@@ -185,16 +185,6 @@ func Start(ctx context.Context, logger *zap.Logger, port int, executorURL string
zap.Duration("default", unTapServiceTimeout))
}
tracingSamplingRateStr := os.Getenv("TRACING_SAMPLING_RATE")
tracingSamplingRate, err := strconv.ParseFloat(tracingSamplingRateStr, 64)
if err != nil {
tracingSamplingRate = .5
logger.Error("failed to parse tracing sampling rate from 'TRACING_SAMPLING_RATE' - set to the default value",
zap.Error(err),
zap.String("value", tracingSamplingRateStr),
zap.Float64("default", tracingSamplingRate))
}
displayAccessLogStr := os.Getenv("DISPLAY_ACCESS_LOG")
displayAccessLog, err := strconv.ParseBool(displayAccessLogStr)
if err != nil {
@@ -222,5 +212,5 @@ func Start(ctx context.Context, logger *zap.Logger, port int, executorURL string
ctx, span := tracer.Start(ctx, "router/Start")
defer span.End()
serve(ctx, logger, port, tracingSamplingRate, triggers, displayAccessLog)
serve(ctx, logger, port, triggers, displayAccessLog)
}