Show warning when referencing nonexistent resources in spec (#1415)

2019-11-18 13:46:28 +08:00
parent 81ece23bfe
commit 3aca0edfcc
7 changed files with 166 additions and 34 deletions
@@ -109,6 +109,28 @@ func (opts *CreateSubCommand) complete(input cli.Input) error {
 		return err
 	}

+	if input.Bool(flagkey.SpecSave) {
+		specDir := util.GetSpecDir(input)
+		fr, err := spec.ReadSpecs(specDir)
+		if err != nil {
+			return errors.Wrap(err, fmt.Sprintf("error reading spec in '%v'", specDir))
+		}
+
+		exists, err := fr.ExistsInSpecs(fv1.Function{
+			Metadata: metav1.ObjectMeta{
+				Name:      fnName,
+				Namespace: fnNamespace,
+			},
+		})
+		if err != nil {
+			return err
+		}
+		if !exists {
+			console.Warn(fmt.Sprintf("MessageQueueTrigger '%v' references unknown Function '%v', please create it before applying spec",
+				mqtName, fnName))
+		}
+	}
+
 	opts.trigger = &fv1.MessageQueueTrigger{
 		Metadata: metav1.ObjectMeta{
 			Name:      mqtName,