use golangci-lint migrate to eliminate error (#3220)

fixes #3219

Signed-off-by: Raymond Augé <raymond.auge@liferay.com>

.golangci.yaml

@@ -1,36 +1,36 @@
+version: "2"
 linters:
   enable:
-    # Default linter
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
-    - typecheck
-    - unused
-    # Additional linters
-    - gofmt
-    - goimports
     - misspell
     - nakedret
-    - unconvert
     - promlinter
-    # Enable in future
+    - unconvert
-    # - bodyclose
+  settings:
-    # - dogsled
+    errcheck:
-    # - dupl
+      exclude-functions:
-    # - gosec
+        - (*go.uber.org/zap.Logger).Sync
-    # - nilerr
+  exclusions:
-    # - prealloc
+    generated: lax
-    # - revive
+    presets:
-    # - unparam
+      - comments
-    # - wrapcheck
+      - common-false-positives
-    # - gocritic
+      - legacy
-linters-settings:
+      - std-error-handling
-  errcheck:
+    paths:
-    exclude-functions:
+      - third_party$
-    - (*go.uber.org/zap.Logger).Sync
+      - builtin$
-  goimports:
+      - examples$
-    # put imports beginning with prefix after 3rd-party packages;
+formatters:
-    # it's a comma-separated list of prefixes
+  enable:
-    local-prefixes: github.com/fission/fission
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/fission/fission
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$