Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Optimize Github action workflows for Go version identification (#2533)

Browse Source 
Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>

Signed-off-by: Sanket Sudake <sanketsudake@gmail.com>
This commit is contained in:
Sanket Sudake
2022-09-06 17:30:21 +05:30
committed by GitHub
parent 7dad7c8399
commit 294ff5bb19
7 changed files with 147 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/codeql.yaml
+4 -5
View File
@@ -27,12 +27,11 @@ jobs:
- name: Check out code
uses: actions/checkout@v3
- uses: actions/cache@v3
- name: setup go
uses: actions/setup-go@v3
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
go-version-file: "go.mod"
cache: true
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
.github/workflows/lint-dashboards.yaml
+3 -3
View File
@@ -18,14 +18,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out code
uses: actions/checkout@v3
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.18.5
- name: Check out code
uses: actions/checkout@v3
- name: Install dashboard linter
run: |
go get github.com/grafana/dashboard-linter
.github/workflows/lint.yaml
+23 -33
View File
@@ -5,67 +5,57 @@ on:
branches:
- main
paths:
- '**.go'
- "**.go"
- go.mod
- go.sum
pull_request:
branches:
- main
paths:
- '**.go'
- "**.go"
- go.mod
- go.sum
workflow_dispatch:
env:
GOLANGCI_LINT_VERSION: v1.49.0
GOLANGCI_LINT_TIMEOUT: 5m
jobs:
lint:
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.19
- name: Check out code
uses: actions/checkout@v3
- uses: actions/cache@v3
- name: Set up Go
uses: actions/setup-go@v3
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
go-version-file: "go.mod"
cache: true
- name: Verify dependencies
run: |
go mod verify
go mod download
LINT_VERSION=1.48.0
curl -fsSL https://github.com/golangci/golangci-lint/releases/download/v${LINT_VERSION}/golangci-lint-${LINT_VERSION}-linux-amd64.tar.gz | \
tar xz --strip-components 1 --wildcards \*/golangci-lint
mkdir -p bin && mv golangci-lint bin/
- name: Run golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: ${{ env.GOLANGCI_LINT_VERSION }}
args: --timeout=${{ env.GOLANGCI_LINT_TIMEOUT }}
- name: Run checks
- name: Detect git changes
if: always()
run: |
STATUS=0
assert-nothing-changed() {
local diff
"$@" >/dev/null || return 1
if ! diff="$(git diff -U1 --color --exit-code)"; then
printf '\e[31mError: running `\e[1m%s\e[22m` results in modifications that you must check into version control:\e[0m\n%s\n\n' "$*" "$diff" >&2
git checkout -- .
STATUS=1
if [[ $(git diff --stat) != '' ]]; then
echo -e '❌ \033[0;31m. Fix lint changes.\033[0m'
git diff --color
exit 1
else
echo '✔ No issues detected. Have a nice day :-)'
fi
}
assert-nothing-changed go fmt ./...
assert-nothing-changed go mod tidy
bin/golangci-lint run --out-format=github-actions --timeout=5m || STATUS=$?
exit $STATUS
- name: Run unit tests
run: ./hack/runtests.sh
.github/workflows/push_pr.yaml
+11 -13
View File
@@ -21,6 +21,10 @@ on:
- go.sum
workflow_dispatch:
env:
HELM_VERSION: v3.9.0
KIND_VERSION: v0.14.0
jobs:
# Job to run change detection
integration-test:
@@ -31,13 +35,14 @@ jobs:
kindversion: ["v1.19.16", "v1.20.15", "v1.21.12"]
os: [ubuntu-latest]
steps:
- name: Checkout sources
uses: actions/checkout@v3
- name: setup go
uses: actions/setup-go@v3
with:
go-version: 1.19
- name: Checkout sources
uses: actions/checkout@v3
go-version-file: "go.mod"
cache: true
- name: Checkout sources
uses: actions/checkout@v3
@@ -45,23 +50,16 @@ jobs:
repository: fission/examples
path: examples
- uses: actions/cache@v3
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- name: Helm installation
uses: Azure/setup-helm@v3
with:
version: v3.3.4
version: ${{ env.HELM_VERSION }}
- name: Kind Clutser
uses: engineerd/setup-kind@v0.5.0
with:
image: kindest/node:${{ matrix.kindversion }}
version: v0.14.0
version: ${{ env.KIND_VERSION }}
config: kind.yaml
- name: Configuring and testing the Installation
.github/workflows/release.yaml
+6 -7
View File
@@ -6,7 +6,6 @@ on:
- v2.**
env:
GO_VERSION: 1.19
KIND_VERSION: v0.14.0
KIND_NODE_IMAGE_TAG: v1.19.16
@@ -14,16 +13,17 @@ jobs:
create-draft-release:
runs-on: ubuntu-latest
steps:
- name: Setup go
uses: actions/setup-go@v3
with:
go-version: ${{ env.GO_VERSION }}
- name: Check out code
uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Setup go
uses: actions/setup-go@v3
with:
go-version-file: "go.mod"
cache: true
- name: Get the version
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
@@ -33,7 +33,6 @@ jobs:
with:
install-only: true
- name: Kind Clutser
uses: engineerd/setup-kind@v0.5.0
with:
.github/workflows/upgrade_test.yaml
+18 -20
View File
@@ -5,56 +5,54 @@ on:
branches:
- main
paths:
- '**.go'
- 'charts/**'
- 'test/**'
- "**.go"
- "charts/**"
- "test/**"
- go.mod
- go.sum
pull_request:
branches:
- main
paths:
- '**.go'
- 'charts/**'
- 'test/**'
- "**.go"
- "charts/**"
- "test/**"
- go.mod
- go.sum
workflow_dispatch:
env:
HELM_VERSION: v3.9.0
KIND_VERSION: v0.14.0
jobs:
upgrade-test:
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
kindimage : [ 'kindest/node:v1.19.16' ]
os: [ ubuntu-latest ]
kindimage: ["kindest/node:v1.19.16"]
os: [ubuntu-latest]
steps:
- name: Setup go
uses: actions/setup-go@v3
with:
go-version: 1.19
- name: Checkout action sources
uses: actions/checkout@v3
- uses: actions/cache@v3
- name: Setup go
uses: actions/setup-go@v3
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
go-version-file: "go.mod"
cache: true
- name: Setup Helm
uses: Azure/setup-helm@v3
with:
version: v3.3.4
version: ${{ env.HELM_VERSION }}
- name: Setup Kind Clutser
uses: engineerd/setup-kind@v0.5.0
with:
image: ${{ matrix.kindimage }}
version: v0.14.0
version: ${{ env.KIND_VERSION }}
- name: Install GoReleaser
uses: goreleaser/goreleaser-action@v2
cmd/builder/main.go
+1 -1
View File
@@ -38,7 +38,7 @@ func main() {
if os.IsNotExist(err) {
err = os.MkdirAll(shareVolume, os.ModeDir|0700)
if err != nil {
logger.Fatal("error creating directory: %v", zap.Error(err), zap.String("directory", shareVolume))
logger.Fatal("error creating directory: %s", zap.Error(err), zap.String("directory", shareVolume))
}
}
}