Nail/fission-src
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Build error formatting on fission spec apply --wait (#1403)

Browse Source 
The character `\n` in buildlog stores in package status
are escaped and so when we have to replace them with
actual line breaker.
This commit is contained in:
Ta-Ching Chen
2019-11-12 21:00:55 +08:00
committed by GitHub
parent a645a1e197
commit 1cda7e051b
5 changed files with 58 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/fission-cli/cmd/spec/buildwatch.go
+6 -8
View File
@@ -26,6 +26,7 @@ import (
fv1 "github.com/fission/fission/pkg/apis/fission.io/v1"
"github.com/fission/fission/pkg/controller/client"
"github.com/fission/fission/pkg/fission-cli/cmd/package/util"
"github.com/fission/fission/pkg/types"
)
@@ -98,15 +99,12 @@ func (w *packageBuildWatcher) watch(ctx context.Context) {
if _, printed := w.finished[k]; printed {
continue
}
if pkg.Status.BuildStatus == types.BuildStatusFailed {
if pkg.Status.BuildStatus == types.BuildStatusFailed ||
pkg.Status.BuildStatus == types.BuildStatusSucceeded {
w.finished[k] = true
fmt.Printf("--- Build FAILED: ---\n%v\n------\n", pkg.Status.BuildLog)
} else if pkg.Status.BuildStatus == types.BuildStatusSucceeded {
w.finished[k] = true
fmt.Printf("--- Build SUCCEEDED ---\n")
if len(pkg.Status.BuildLog) > 0 {
fmt.Printf("%v\n------\n", pkg.Status.BuildLog)
}
fmt.Printf("------\n")
util.PrintPackageSummary(os.Stdout, &pkg)
fmt.Printf("------\n")
}
}