Change log-level for better performance and less annoying logs (#1231)

This PR removes not so useful logs and changes most of Info level
log to Debug/Error level in hot path while preserving some of them
that is helpful for troubleshooting.

pkg/controller/api.go

@@ -34,7 +34,6 @@ import (
 	ferror "github.com/fission/fission/pkg/error"
 	"github.com/fission/fission/pkg/fission-cli/logdb"
 	"github.com/fission/fission/pkg/info"
-	"github.com/fission/fission/pkg/utils"
 )
 
 var podNamespace string
@@ -274,7 +273,6 @@ func (api *API) Serve(port int) {
 	address := fmt.Sprintf(":%v", port)
 
 	api.logger.Info("server started", zap.Int("port", port))
-	r.Use(utils.LoggingMiddleware(api.logger))
 	err := http.ListenAndServe(address, r)
 	api.logger.Fatal("done listening", zap.Error(err))
 }

pkg/controller/controller.go

@@ -22,13 +22,10 @@ import (
 	"go.uber.org/zap"
 
 	"github.com/fission/fission/pkg/crd"
-	"github.com/fission/fission/pkg/utils"
 )
 
 func Start(logger *zap.Logger, port int, unitTestFlag bool) {
 	cLogger := logger.Named("controller")
-	// setup a signal handler for SIGTERM
-	utils.SetupStackTraceHandler()
 
 	fc, kc, apiExtClient, err := crd.MakeFissionClient()
 	if err != nil {
@@ -48,7 +45,7 @@ func Start(logger *zap.Logger, port int, unitTestFlag bool) {
 	ctx, cancel := context.WithCancel(context.Background())
 	featureStatus, err := ConfigureFeatures(ctx, cLogger, unitTestFlag, fc, kc)
 	if err != nil {
-		cLogger.Info("error configuring features - proceeding without optional features", zap.Error(err))
+		cLogger.Error("error configuring features - proceeding without optional features", zap.Error(err))
 	}
 	defer cancel()