From 1358aa2a81f938d016519bc305802a7e7fec15de Mon Sep 17 00:00:00 2001 From: LiuXiang Date: Thu, 2 Jan 2025 00:43:36 +0800 Subject: [PATCH] Log only related configmap and secret (#3049) Signed-off-by: LiuXiang --- pkg/executor/cms/cmhandler.go | 11 ++++++++--- pkg/executor/cms/secrethandler.go | 11 ++++++++--- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/pkg/executor/cms/cmhandler.go b/pkg/executor/cms/cmhandler.go index 24d4247d..244c819a 100644 --- a/pkg/executor/cms/cmhandler.go +++ b/pkg/executor/cms/cmhandler.go @@ -58,13 +58,18 @@ func ConfigMapEventHandlers(ctx context.Context, logger *zap.Logger, fissionClie oldCm := oldObj.(*apiv1.ConfigMap) newCm := newObj.(*apiv1.ConfigMap) if oldCm.ObjectMeta.ResourceVersion != newCm.ObjectMeta.ResourceVersion { - logger.Debug("Configmap changed", - zap.String("configmap_name", newCm.ObjectMeta.Name), - zap.String("configmap_namespace", newCm.ObjectMeta.Namespace)) funcs, err := getConfigmapRelatedFuncs(ctx, logger, &newCm.ObjectMeta, fissionClient) if err != nil { logger.Error("Failed to get functions related to configmap", zap.String("configmap_name", newCm.ObjectMeta.Name), zap.String("configmap_namespace", newCm.ObjectMeta.Namespace)) } + + if len(funcs) == 0 { + return + } + + logger.Debug("Configmap changed", + zap.String("configmap_name", newCm.ObjectMeta.Name), + zap.String("configmap_namespace", newCm.ObjectMeta.Namespace)) refreshPods(ctx, logger, funcs, types) } }, diff --git a/pkg/executor/cms/secrethandler.go b/pkg/executor/cms/secrethandler.go index 20d6151d..ff6fd6dc 100644 --- a/pkg/executor/cms/secrethandler.go +++ b/pkg/executor/cms/secrethandler.go @@ -57,13 +57,18 @@ func SecretEventHandlers(ctx context.Context, logger *zap.Logger, fissionClient oldS := oldObj.(*apiv1.Secret) newS := newObj.(*apiv1.Secret) if oldS.ObjectMeta.ResourceVersion != newS.ObjectMeta.ResourceVersion { - logger.Debug("Secret changed", - zap.String("configmap_name", newS.ObjectMeta.Name), - zap.String("configmap_namespace", newS.ObjectMeta.Namespace)) funcs, err := getSecretRelatedFuncs(ctx, logger, &newS.ObjectMeta, fissionClient) if err != nil { logger.Error("Failed to get functions related to secret", zap.String("secret_name", newS.ObjectMeta.Name), zap.String("secret_namespace", newS.ObjectMeta.Namespace)) } + + if len(funcs) == 0 { + return + } + + logger.Debug("Secret changed", + zap.String("secret_name", newS.ObjectMeta.Name), + zap.String("secret_namespace", newS.ObjectMeta.Namespace)) refreshPods(ctx, logger, funcs, types) } },