From 11baffc92c101bb4effeac81ccc6b13bc4874652 Mon Sep 17 00:00:00 2001 From: waitstory Date: Fri, 30 Aug 2024 19:24:41 +0800 Subject: [PATCH] Fixed time unit loss problem after converting time (#3004) The time unit of 'function.Spec.FunctionTimeout' is second, but after conversion from the function time.Duration, the unit becomes nanosecond. So it needs to be repaired. Signed-off-by: waitstory --- pkg/fission-cli/cmd/function/test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/fission-cli/cmd/function/test.go b/pkg/fission-cli/cmd/function/test.go index c71160f2..ce224750 100644 --- a/pkg/fission-cli/cmd/function/test.go +++ b/pkg/fission-cli/cmd/function/test.go @@ -108,7 +108,7 @@ func (opts *TestSubCommand) do(input cli.Input) error { ) fnTestTimeout := input.Duration(flagkey.FnTestTimeout) - fnSpecTimeout := time.Duration(function.Spec.FunctionTimeout) + fnSpecTimeout := time.Duration(function.Spec.FunctionTimeout) * time.Second if input.IsSet(flagkey.FnTestTimeout) && (fnTestTimeout < fnSpecTimeout) { reqTimeout = fnTestTimeout @@ -121,7 +121,7 @@ func (opts *TestSubCommand) do(input cli.Input) error { ctx = input.Context() } else { var closeCtx context.CancelFunc - ctx, closeCtx = context.WithTimeoutCause(input.Context(), reqTimeout*time.Second, fmt.Errorf("function request timeout (%d)s exceeded", reqTimeout)) + ctx, closeCtx = context.WithTimeoutCause(input.Context(), reqTimeout, fmt.Errorf("function request timeout (%d)s exceeded", reqTimeout)) defer closeCtx() }